Add wc_Sha256Free after the final use#930
Merged
ejohnstown merged 1 commit intowolfSSL:masterfrom Apr 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates src/agent.c to properly release wolfCrypt SHA-256 contexts by adding wc_Sha256Free() calls after the final use of stack-local wc_Sha256 variables, preventing resource leaks in agent key ID hashing paths.
Changes:
- Add
wc_Sha256Free(&sha)afterwc_Sha256Final()inPostAddRsaId(). - Add
wc_Sha256Free(&sha)afterwc_Sha256Final()inPostAddEcdsaId(). - Add
wc_Sha256Free(&sha)afterwc_Sha256Final()inPostRemoveId()andFindKeyId().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ejohnstown
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four functions in agent.c call wc_InitSha256() followed by wc_Sha256Update() and wc_Sha256Final() on a stack-local wc_Sha256 variable, but never call wc_Sha256Free().
This PR adds it into each function after the final use of the sha context.